Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation notices on PartialAmount params #16505

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Feb 10, 2020

Overview

Adds deprecation notices to passing partial_amount_to_pay to Contribution.create

Before

No notice

After

Notice

Technical Details

We've removed all the places that pass these in so these 2 places handling them are the only remaining references.

All calling code now uses Payment.create to add the payments - yay. Removing these fully will clean up the code
notably

Comments

We've removed all the places that pass these in so these 2 places handling them are the only remaining references.

All calling code now uses Payment.create to add the payments - yay. Removing these fully will clean up the code
notably
@civibot civibot bot added the master label Feb 10, 2020
@civibot
Copy link

civibot bot commented Feb 10, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

@monishdeb follow up on #16442

@monishdeb
Copy link
Member

Agree with these notices. Merging now.

@monishdeb monishdeb merged commit 82a5a4f into civicrm:master Feb 11, 2020
@eileenmcnaughton eileenmcnaughton deleted the part_pay_dep branch February 11, 2020 19:56
@eileenmcnaughton
Copy link
Contributor Author

@monishdeb yay - we are moving towards readable code slowly but surely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants