Add deprecation notices on PartialAmount params #16505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds deprecation notices to passing partial_amount_to_pay to Contribution.create
Before
No notice
After
Notice
Technical Details
We've removed all the places that pass these in so these 2 places handling them are the only remaining references.
All calling code now uses Payment.create to add the payments - yay. Removing these fully will clean up the code
notably
Comments