Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable jQuery validate on register/contribution forms #16494

Merged
merged 1 commit into from
Feb 7, 2020

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Feb 7, 2020

Overview

This makes jQuery validate available by default on frontend contribution / registration forms. Any site with Stripe enabled has been using this for about a year now.

Partial from #16488

Before

jQuery validate not available on frontend forms by default.

After

jQuery validate available on frontend forms.

Technical Details

This activates jquery validation (client-side validation) for forms. Which does nothing by itself but allows you to run eg. CRM.$('#Main').valid() and get a true/false response, also fields will show a "field is required" message.

Comments

@eileenmcnaughton Think you had an interest in the past?

@civibot
Copy link

civibot bot commented Feb 7, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

This has also been enabled via the Omnipay processor - I think at the time I wanted to make this change but went with the more precautionary approach. However, I think this has had analysis & prod testing & this point in the cycle is good timing.

Also jquery validate is better than the slow way....

@seamuslee001 seamuslee001 merged commit 7632d43 into civicrm:master Feb 7, 2020
@mattwire mattwire deleted the enablevalidate branch March 23, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants