Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throwing API_Exception is file fails to copy when creating attachment… #16465

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Throwing API_Exception is file fails to copy when creating attachment… #16465

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd05fc5
Throwing API_Exception is file fails to copy when creating attachment…
albionbrown Feb 4, 2020
cecec98
Update api/v3/Attachment.php to remove concatenation
albionbrown Feb 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions api/v3/Attachment.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,10 @@ function civicrm_api3_attachment_create($params) {
}
elseif (is_string($moveFile)) {
// CRM-17432 Do not use rename() since it will break file permissions.
// Also avoid move_uplaoded_file() because the API can use options.move-file.
copy($moveFile, $path);
// Also avoid move_uploaded_file() because the API can use options.move-file.
if (!copy($moveFile, $path)) {
throw new API_Exception("Cannot copy uploaded file ".$moveFile." to ".$path);
albionbrown marked this conversation as resolved.
Show resolved Hide resolved
}
unlink($moveFile);
}

Expand Down