Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass language code to CiviCRM for Wordpress #16446

Merged
merged 1 commit into from
Feb 3, 2020

Conversation

mattwire
Copy link
Contributor

Overview

Fixes a @todo in the code :-)

Wordpress still has a language even if it only has one. Pass that language to CiviCRM instead of NULL.

Before

We don't pass the configured language to CiviCRM

After

We pass the configured language to CiviCRM

Technical Details

Comes out of #16289

Comments

@christianwach @kcristiano This is pretty straightforward and fixes a todo in the code. It means CiviCRM will always pick up the language that wordpress is configured instead of having to configure both separately!

@civibot
Copy link

civibot bot commented Jan 31, 2020

(Standard links)

@civibot civibot bot added the master label Jan 31, 2020
@mlutfy
Copy link
Member

mlutfy commented Feb 3, 2020

@kcristiano or @christianwach If this looks OK to you, this seems good to merge?

@christianwach
Copy link
Member

@mlutfy I promised I'd review @mattwire's Polylang stuff this week - but this looks trivial and I'd be more than happy to see it merged.

@mlutfy mlutfy merged commit fd4987d into civicrm:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants