Respect form value for register_date on partipant form #16439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backoffice event registration form has a register_date field. In credit card mode it does an awful lot of handling which is mostly for legacy code reasons but the net result is to ignore it & set it to now. However, the field defaults to now & if someone actually changed it they would expect their change to be respected. This removes that handling & just uses the field value entered. The field is always present from my digging
|
(Standard links)
|
| is_array($params['participant_register_date']) && | ||
| !empty($params['participant_register_date']) | ||
| ) { | ||
| $registerDate = CRM_Utils_Date::format($params['participant_register_date']); |
There was a problem hiding this comment.
this is handling for pre-datepicker days
|
Looks fine @eileenmcnaughton do you think we would ever want to expose the field on edit at all? |
|
@seamuslee001 I think it is exposed & I think that makes sense - I mean why not be able to edit the registration date? Backoffice users should have the power I think |
|
yeh got confuzzled there for a moment all good added MOP |
|
Jenkins re test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes a bug whereby the participant registration date is exposed on a field on the backoffice event form, but when a credit card payment is being submitted it is ignored
Before
Registration date field always present, but ignored in credit card mode
After
Value entered is used
Technical Details
The backoffice event registration form has a register_date field. In credit card mode it
does an awful lot of handling which is mostly for legacy code reasons but the net result is to ignore it
& set it to now. However, the field defaults to now & if someone actually changed it they would expect their change to
be respected. This removes that handling & just uses the field value entered. The field is always present from my
digging
Comments