dev/core#1558 [REF] Remove deprecated code from CRM_Admin_Form_Preferences #16398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This form was cleaned up back in 2018 but all the stuff to handle ->_varNames was deprecated rather than removed in case extensions were leveraging it in some way. I'm removing it now although I commented rather than removed a few lines that I suspect can also go
|
(Standard links)
|
|
test this please |
|
@eileenmcnaughton all the tests pass. I reckon this is ready to merge. |
|
I reviewed this and agree with @yashodha 's comment, these have been generating notices for a while and if someone had an issue i am sure they would have piped up now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove unused code from preferences form base class
Before
Code supporting $this->_varNames deprecated
After
Code supporting $this->_varNames removed
Technical Details
This form was cleaned up back in 2018 but all the stuff to handle $this->_varNames was deprecated rather than
removed in case extensions were leveraging it in some way. I'm removing it now although I commented rather
than removed a few lines that I suspect can also go
Comments