Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1550 Invalid links to extension directory in popup help text #16394

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

There's two places where the popup help text has invalid links.

https://lab.civicrm.org/dev/core/issues/1550

Before

At administer - customize - display preferences:

wysiwig


And at administer - system settings - payment processors:

paymentprocessor

After

Good links

Comments

I waffled over whether to change these to just links to https://civicrm.org/extensions, which will be more maintainable, and when civicrm.org changes to drupal 8 these might change again so the bare link might be more easily redirectable. For now I've kept their original intent but will do whatever.

@civibot
Copy link

civibot bot commented Jan 27, 2020

(Standard links)

@civibot civibot bot added the master label Jan 27, 2020
@eileenmcnaughton
Copy link
Contributor

I confirmed that the links work on the test-generated site.

@eileenmcnaughton eileenmcnaughton merged commit f2858e1 into civicrm:master Jan 28, 2020
@demeritcowboy
Copy link
Contributor Author

Thanks

@demeritcowboy demeritcowboy deleted the extdir-links branch January 28, 2020 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants