Prevent PropertBag from being so noisy about deprecation warnings

[artfulrobot]

Overview

Turns out calling Civi::log() can be problematically slow (like taking over 0.5s/call) on some hosting environments. Currently there's a lot of core that is not updated to use Civi\Payment\PropertyBag yet, and that class was deliberately built to make noise about this. This resulted in a problematic performance hit for sites with slow logging.

See https://chat.civicrm.org/civicrm/pl/c9bwzmtrg7dhircfyfei5fezge

Before

PropertyBag would emit Civi::warning() synchronously every time it encountered deprecated use.

After

PropertyBag now stores all these complaints up and registers a shutdown function to write them to the log in one go.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[artfulrobot]

Nb. It also tags that message with civi.tag => deprecated - I'm not sure if that's desired or not.

[artfulrobot]

Tagging @mattwire and @totten who both expressed opinions on this in chat.

[mattwire]

Thanks @artfulrobot - tested and confirmed this fixes the issue.

[artfulrobot]

awesome. good reminder that we need to go back through the code that's calling it!