APIv4 - don't throw exception when updating/deleting 0 items

[colemanw]

Overview

When 0 items are found to be processed by batch actions, it's not really an error so we shouldn't throw an exception.

Before

*UpdateAction and DAODeleteAction throw exceptions when 0 items found.

After

No exception, just returns an empty result.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

test fails relate here @colemanw

[alifrumin]

I tested this and it works as described and seems sensible.

BEFORE this change:

Attempting a CiviCRM API4 delete call with no records found resulted in an error message like "Cannot delete Activity, no records found with subject = 1111"

WITH this change it results in an empty array.

[eileenmcnaughton]

@colemanw this is a philosophical difference to apiv3 - being able to do things differently is obviously part of the point of apiv4 - but is it documented clearly as a difference?

[artfulrobot]

As someone new to API v4, I have to admit I see it more like a SQL query builder than an API like V3.

As such I was surprised that a delete call (which allows multiple deletions now, like SQL) threw an exception if there was nothing to delete.

So I think this change is sensible.

Api3 was/is full of inconsistencies around how records can be specified, so I think this pr makes apiv4 more consistent and easier to document.

[eileenmcnaughton]

I'm not opposed I just think this is a 'needs documentation'

[colemanw]

I started to add docs to this then realized that Update currently works the same way. It throws an exception if 0 records are found to update. That also feels wrong to me (as in, not what SQL does), so I'd like to change that too.
Any objections?

[artfulrobot]

Not from me. It seems correct on something that takes search parameters that it should deal with whatever results there are or aren't.

[colemanw]

Update: I've updated this PR to update Update and also updated the docs 😆

civicrm/civicrm-dev-docs@f0232d2