event#30 - don't allow multiple waitlist registrations #16358
Conversation
|
(Standard links)
|
|
test this please |
|
@MegaphoneJon I tested this & was able to replicate it. It has a test & change seems sensible. However, I do think the message you get if you are already waitlisted is a bit confusing - ie
People could think they have already been accepted? |
|
I considered that. I feel like the word "registered" is overloaded here - arguably any participant record represents a "registration", but it's also a participant status. I think we're overly sensitive to the second definition, while the first is more colloquial, but there's no harm in changing the word "registered" to "waitlisted" here in that message. |
|
@MegaphoneJon I'm OK with merging this as an improvement & leaving that for more pondering |
011ee39 to
ed66ac4
Compare
|
No need :) |
|
@MegaphoneJon @eileenmcnaughton looks good, merging this as per consensus |
| @@ -1196,8 +1197,9 @@ public static function checkRegistration($fields, $form, $isAdditional = FALSE) | |||
| if ($form->_pcpId) { | |||
| $registerUrl .= '&pcpId=' . $form->_pcpId; | |||
| } | |||
|
|
|||
| $status = ts("It looks like you are already registered for this event. If you want to change your registration, or you feel that you've received this message in error, please contact the site administrator.") . ' ' . ts('You can also <a href="%1">register another participant</a>.', [1 => $registerUrl]); | |||
| $registrationType = (CRM_Event_PseudoConstant::getKey('CRM_Event_BAO_Participant', 'participant_status_id', 'On waitlist') == $participant->status_id) ? 'waitlisted' : 'registered'; | |||
There was a problem hiding this comment.
Seeing this late, but this is a good example of an incorrect use of "ts". It's impossible to translate a string like this, even if the individual words were in "ts" (because of grammar).
https://lab.civicrm.org/dev/event/issues/30
Overview
CRM-2426 prevents multiple front-end registrations of an event participant whose status is "Counted", but allows someone to register for the waitlist multiple times.
Before
Waitlisted users are allowed to generate as many waitlist entries as they like.
After
Waitlisted users get the same feedback as "counted" users when attempting to re-register.
Technical Details
The Event Participant Status
is_countedandclassboth try to capture different ways of grouping statuses, but "On waitlist" is and will always be a special case when determining whether a person is registered.