Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Api4 - Improve Entity::get #16346

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Api4 - Improve Entity::get #16346

merged 1 commit into from
Jan 22, 2020

Conversation

colemanw
Copy link
Member

Overview

  • Ensure that every php file found by the scanner is_a class inheriting from AbstractEntity.
  • Remove the CustomValue class by virtue of its class type instead of manually remove it.
  • Improve performance when fetching entities by name.

@colemanw
Api4 - Improve Entity::get
7b7c96e 
Ensure that every php file found by the scanner is_a class inheriting from AbstractEntity.
Remove the CustomValue class by virtue of its class type instead of manually remove it.
Improve performance when fetching entities by name.
@totten
Copy link
Member

totten commented Jan 21, 2020

This section of code has pretty good unit-test coverage, doesn't it?

@colemanw
Copy link
Member Author

@totten yes it does.

@eileenmcnaughton eileenmcnaughton merged commit 0ee140e into civicrm:master Jan 22, 2020
@eileenmcnaughton eileenmcnaughton deleted the entityGet branch January 22, 2020 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colemanw @totten @eileenmcnaughton