Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit test so price set params are valid #16344

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Fix unit test so price set params are valid #16344

merged 1 commit into from
Jan 21, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fix test to be more valid

Before

Values passed for price_x are not 'real'

After

Values relate to valid options

Technical Details

Comments

@seamuslee001
Copy link
Contributor

@eileenmcnaughton the test fail CRM_Event_Form_ParticipantTest::testSubmitUnpaidPriceChangeWhileStillPending looks related here

@eileenmcnaughton
Copy link
Contributor Author

unrelated fail

@eileenmcnaughton eileenmcnaughton merged commit 35667d5 into civicrm:master Jan 21, 2020
@eileenmcnaughton eileenmcnaughton deleted the ev_test branch January 21, 2020 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-test master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001