Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Remove unused local variables from CRM_Contribute_Form_AdditionalPayment::processCreditCard #16342

Merged
merged 2 commits into from
Jan 21, 2020
Merged

[NFC] Remove unused local variables from CRM_Contribute_Form_AdditionalPayment::processCreditCard #16342

merged 2 commits into from
Jan 21, 2020

Conversation

JKingsnorth
Copy link
Contributor

Overview

Remove unused local variable $fields in \CRM_Contribute_Form_AdditionalPayment::processCreditCard. Hinted by PHPStorm unused ocal variable code inspection, and checked manually.

@civibot
Copy link

civibot bot commented Jan 20, 2020

(Standard links)

@civibot civibot bot added the master label Jan 20, 2020
@JKingsnorth JKingsnorth changed the title Remove unused local variable $fields from CRM_Contribute_Form_AdditionalPayment::processCreditCard [NFC] Remove unused local variable $fields from CRM_Contribute_Form_AdditionalPayment::processCreditCard Jan 20, 2020
@JKingsnorth JKingsnorth changed the title [NFC] Remove unused local variable $fields from CRM_Contribute_Form_AdditionalPayment::processCreditCard [NFC] Remove unused local variables from CRM_Contribute_Form_AdditionalPayment::processCreditCard Jan 20, 2020
@eileenmcnaughton
Copy link
Contributor

test this please

@seamuslee001
Copy link
Contributor

Test fail unrelated

@seamuslee001 seamuslee001 merged commit edbc50b into civicrm:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwire mattwire mattwire left review comments

Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JKingsnorth @eileenmcnaughton @seamuslee001 @mattwire