Convert civicrm_note.modified_date to timestamp

[mattwire]

Overview

civicrm_note.modified_date is currently a "date" format and does not store the time. This is problematic because sorting in the UI by the default "Modified Date" doesn't necessarily put notes in the right order.

Before

civicrm_note.modified_date does not store time.

After

civicrm_note.modified_date stores date and time.

Technical Details

As the default for a timestamp field is "now" we don't need to pass in a default to the BAO.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Test fail relates.

I should note I can't think of a situation where this would cause a problem but I'd like to see a couple more people weigh on on the concept-approved side of this

[mattwire]

@colemanw This seems to be failing on the API4 test - any ideas why? With API3 removing the modified_date parameter means it uses the database default which is current_timestamp() but it looks like api4 is not doing that here?

[simonjohnparker]

Hi - this appears to be working correctly on our CiviCRM instance.

Thanks,

[irritatie]

We tested this in the latest CiviCRM release and found no issues. Also did an automated full test of basic CiviCRM functionality and everything worked fine. Thanks!

[eileenmcnaughton]

Code & test look OK - merging based on described testing