Change function buildEventFeeForm to non-static

[eileenmcnaughton]

Overview

Change function buildEventFeeForm to non-static

Before

public static function buildEventFeeForm(&$form) {

After

public function buildEventFeeForm($form) {

Technical Details

I searched on thee full function name & also 'buildEvent' & 'feeForm' and I don't believe this is called
from outside this function. I want to call it from tests to fix some test set up issues butt
there are a bunch of undefined properties so I concluded I should set this up first.

Also passing form by reference is unnecessary

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[eileenmcnaughton]

test this please

[demeritcowboy]

• General standards
  • [r-explain] PASS
  • [r-user] PASS
  • [r-doc] PASS
  • [r-run] PASS
    • The messages seem to all work from front and backoffice. Also checked waitlist messages/functionality.
• Developer standards
  • [r-tech] PASS
    • Agree it doesn't seem to be called from elsewhere.
  • [r-code] PASS with comment
    • A next logical step would be to remove the parameter completely and replace $form with $this in the function, since passing $this to $this doesn't add anything.
  • [r-maint] PASS (Description suggests there's a test coming.)
  • [r-test] PASS

[seamuslee001]

agree with @demeritcowboy 's review here merging

[eileenmcnaughton]

Thanks @demeritcowboy & @seamuslee001 & yes - totally agree about removing $form