(WIP) dev/core#1331 Don't freeze fields for auto-renew memberships

[wmortada]

Overview

If a membership is set to auto-renew some of the fields are frozen, which means that a user is unable to edit them when they visit the edit membership screen.

This PR changes this behaviour so that these fields are frozen only if the auto-renew can be cancelled. If the membership is auto-renew but can't be cancelled the fields aren't frozen and can be edited with an appropriate warning.

See https://lab.civicrm.org/dev/core/issues/1331 for more details and discussion.

Before

If the membership is set to auto-renew, the following fields are frozen (whether or not the auto-renew can be cancelled):

• Membership organisation / Membership type
• Membership status

After

If the membership is set to auto-renew and it is possible to cancel the auto-renewal the fields are frozen (no change).

If the membership is set to auto-renew and it is not possible to cancel the auto-renewal the fields are not frozen and the user has the ability to override them if required. Help text with an appropriate warning is displayed.

Technical Details

None

Comments

The end date field was unfrozen in #15505. See https://lab.civicrm.org/dev/core/issues/1126 for details.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[wmortada]

The test failed with an error:

During parsing an error has been reported.

The error itself is:

No report files were found. Configuration error?

Not sure what that means.

[demeritcowboy]

@wmortada You need to rebase the .tpl. If you click on Console Output at the left when viewing the test result you'll see the error.

[wmortada]

@demeritcowboy thanks. I'll take a look.

[wmortada]

Closing in favour of #16609