event#28: Don't send scheduled reminders for event templates #16311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
tests/phpunit/api/v3/JobTest.php
Outdated
|
|
||
| $this->callAPISuccess('job', 'send_reminder', []); | ||
| $successfulCronCount = CRM_Core_DAO::singleValueQuery("SELECT count(*) FROM civicrm_action_log"); | ||
| echo "cronCount:" . $successfulCronCount; |
There was a problem hiding this comment.
@MegaphoneJon can you remove this?
tests/phpunit/api/v3/JobTest.php
Outdated
| $this->callAPISuccess('job', 'send_reminder', []); | ||
| $successfulCronCount = CRM_Core_DAO::singleValueQuery("SELECT count(*) FROM civicrm_action_log"); | ||
| echo "cronCount:" . $successfulCronCount; | ||
| $this->assertEquals($successfulCronCount, 0); |
There was a problem hiding this comment.
This needs to be the other way around the expected value goes first (odd i know)
b537f8f to
ce317e6
Compare
|
@MegaphoneJon this looks good -there is a style warning |
ce317e6 to
5056241
Compare
|
@eileenmcnaughton does that mean merge on pass? |
|
@MegaphoneJon yes - but it didn't pass |
5056241 to
5b4d40a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If you create an event template with a scheduled reminder, and that scheduled reminder is set to go to Additional Participants, the template itself will generate scheduled reminders to the additional participants.
Before
People get emailed erroneously.
After
No erroneous emails.