dev/mailing#59 Update the version of zetacomponents/mail package to b… #16306
Conversation
|
(Standard links)
|
|
@seamuslee001 can you instead update it to v1.9.0 or is a specific git commit still needed? |
….9.0 to be one that potentially will support XAUTH2 for google purposes
429768a to
ec88fef
Compare
| @@ -48,7 +48,7 @@ | |||
| "tecnickcom/tcpdf" : "6.2.*", | |||
| "totten/ca-config": "~17.05", | |||
| "zetacomponents/base": "1.9.*", | |||
| "zetacomponents/mail": "dev-master", | |||
| "zetacomponents/mail": "1.9.*", | |||
There was a problem hiding this comment.
Theoretically we could use ^1.9 here? Because later 1.x releases won't break compatibility - unless they do :)
There was a problem hiding this comment.
in theory yes but just figured go for the simplest approach right,
There was a problem hiding this comment.
If we did that wouldn't we also need to do that for "zetacomponents/base" as well?
I'm happy to merge this PR and have that be a separate discussion.
There was a problem hiding this comment.
Sure go ahead and merge.
Just thinking that it's best to not be overly restrictive on updates until you know there is (or is likely to be) a problem.
There was a problem hiding this comment.
Looks like zetacomponents/mail:1.9.0 requires zetacomponents/base:~1.8
|
test fail unrelated |
…e one that potentially will support XAUTH2 for google purposes
Overview
This updates the version of zetacomponents/mail following my PR zetacomponents/Mail#78 being merged in
ping @eileenmcnaughton @demeritcowboy @mfb