Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] code cleanup #16301

Merged
merged 1 commit into from
Jan 16, 2020
Merged

[NFC] code cleanup #16301

merged 1 commit into from
Jan 16, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Swap out some fatals for exceptions, use single quotes, strict comparison

Before

Use of deprecated fatal

After

Exceptions

Technical Details

Comments

@eileenmcnaughton
[NFC] code cleanup
3676959 
Swap out some fatals  for exceptions, use single quotes,  strict comparison
@civibot
Copy link

civibot bot commented Jan 16, 2020

(Standard links)

@civibot civibot bot added the master label Jan 16, 2020
@seamuslee001 seamuslee001 merged commit 0b41e24 into civicrm:master Jan 16, 2020
@seamuslee001 seamuslee001 deleted the cust_clean branch January 16, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001