Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/user-interface#13 fix regression where option to email is not longer displayed #16292

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Jan 14, 2020

Overview

Fixes recent regression where option to send an email is no longer offered on standalone contribution form

https://lab.civicrm.org/dev/user-interface/issues/13

Before

Option to send an email missing

After

Screen Shot 2020-01-15 at 10 02 52 AM

Technical Details

The api parameter here was removed, seemingly unintentionally. It is picked up on by the script when it checks for email here

if (data && data.extra && data.extra.email && data.extra.email.length) {
- so
needs re-instating

Comments

…ger displayed.

The api parameter here was removed, seemingly unintentionally. It is picked up on by the script when it checks for email so
needs re-instating
@civibot
Copy link

civibot bot commented Jan 14, 2020

(Standard links)

@civibot civibot bot added the 5.22 label Jan 14, 2020
@eileenmcnaughton eileenmcnaughton changed the title dev/user-interface#13 fix regression where option to email is not lon… dev/user-interface#13 fix regression where option to email is not longer displayed Jan 14, 2020
@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.2)

@alifrumin
Copy link
Contributor

Thanks @eileenmcnaughton and @seamuslee001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants