Add "Contributor Name" to Offline Contribution Receipts

[alifrumin]

Overview

Adds the display name of the contributor to the Offline Contribution Receipt.

Offline Contribution Receipts can be triggered by going to a contacts "Contributions" tab and clicking the "Record Contribution (Check, Cash, EFT)" button or the "Submit Credit Card Contribution" button, entering information for a contribution, checking the "Send Receipt?" checkbox and submitting the form.

Before

Without this change Offline Contribution Receipts do not include the Contributors name. See screenshot of a receipt generated from the "Record Contribution (Check, Cash, EFT)" form:

After

With this change they do see screenshot below:

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@alifrumin Is the test failure related?

[alifrumin]

@yashodha the test failure (CRM_Contribute_Form_ContributionTest.testEmailReceiptOnPayLater) was related! The test is looking for a specific string in the receipt and I put the "Contributor Name" right in the middle of it. I changed the order so now the "Contributor Name" should be before the string the test is looking for and not break the test.... fingers crossed.

[alifrumin]

jenkins retest this please

[eileenmcnaughton]

@alifrumin would this look a bit odd if their display name was an email? I think this seems Ok but I'd want a couple more +1s on it as message template changes do have a visible user impact and unlike recent changes this isn't a continuance of changes already discussed

@MegaphoneJon @Stoob

[eileenmcnaughton]

I added has -test as test fails demonstrate existing cover

[alifrumin]

I don't think this most recent test failure is related.

@eileenmcnaughton thank you for adding those labels!

We had a client complain that for offline backend contribution receipts the Contributor's Name never shows up which is how this pr came up in the first place. They specifically wanted the first and last name in the receipt.

The other contribution workflows do seem to have the full name one way or another:

• If one makes a backend contribution using a credit card the billing name shows up with the billing address.
• from the front end you usually have the first and last name as fields on the form (and thus rows in the receipt).

[eileenmcnaughton]

tes this please

[alifrumin]

jenkins retest this please

[Stoob]

Display name as email only is acceptable IMHO. Even if it 'looks weird' it is not inaccurate, and most contribution profiles contain name as well as email address at some point, even if it is the Billing First Name.

[agh1]

@eileenmcnaughton my biggest concern was that a receipt that doesn't identify the donor isn't really a receipt. If the email address is all we know about a donor, that's still important to provide.

[Stoob]

A conversation wouldn't be complete without a tangent, would it? This is what happens with 'offline' event registrations in 5.20.3. The identity of the registrant is not included. This is not the behavior with 'online' registrations for the same event. Is this issue related?

[alifrumin]

@Stoob @agh1 opened an issue regarding the inconsistency between offline receipts here: https://lab.civicrm.org/dev/user-interface/issues/13

It is related in the sense that the Registrant Name not being included I think stems from the same oversight.

[alifrumin]

jenkins retest this please

[eileenmcnaughton]

Nothing show-stopping in the responses here - merging