dev/drupal#89 Drupal 8 version of checkGroupRole

[demeritcowboy]

Overview

Follow-on from #15318. The UI for the roles widget on the Access tab of CiviReports is fixed by that PR but it doesn't actually have any effect on access because the implementation of CRM_Core_Permission::checkGroupRole ends up using the D6/D7 version which doesn't work in D8. So that needed updating too, which is this PR.

Before

You can select a role but it doesn't affect access.

After

Role-based access works like in D7.

Technical Details

$GLOBALS['user'] doesn't exist in D8. This adds an override version of checkGroupRole in Drupal8.php.

Comments

If you're testing note that if the user has Administer Reports permission in the CMS then that overrides anything on the access tab of a report.

@jitendrapurohit

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

jenkins retest this please

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass
  • (r-doc) Pass
  • (r-run) I tested this by making a specific report available to a specific role. Granted a test user that specific role, confirmed without this patch they couldn't access the role, confirmed that with the patch they could access the report. Also confirmed that if the report was limited to a role that the user didn't have it blocked access.
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass
  • (r-test) Pass

[demeritcowboy]

Thanks