dev/core#1471 - Add system status alert for deleted custom fields in …

[jitendrapurohit]

…smart groups

Overview

Add message alert on system status page for deleted custom fields on smart group.

Before

See https://lab.civicrm.org/dev/core/issues/1471. There is no indication or way to know which smart groups are responsible for errors on the group page.

After

System status show an alert with a list of groups responsible for smart group errors.

UPDATED text after QA -

Comments

Gitlab - https://lab.civicrm.org/dev/core/issues/1471

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[francescbassas]

In the alert message, instead of deleting problematic smart groups, I might suggest editing their search criteria and updating them to clean outdated fields from saved search.

[jitendrapurohit]

@francescbassas updated the msg to suggest editing and updating the search criteria. Also updated the table to list custom field labels of deleted fields that are included in the saved search form values.

[francescbassas]

Great, looks better!

Custom field value isn't displayed in my case. Maybe because they are deleted and not disabled?

I would also add a ✏️ and ⚙️ to each row to link to the group search criteria edition .../civicrm/contact/search/advanced?reset=1&ssID=5 or the settings page to deactivate it civicrm/group?reset=1&action=update&id=5.

[yashodha]

@jitendrapurohit @francescbassas Edit/settings button sound good. Can the list be group title which is link to the results as well.

[francescbassas]

In the column Custom field I would put:

• Deleted (red color) - if field has been removed
• The name of the field (disabled color with a link to edit group ...civicrm/admin/custom/group/field/update?action=update&reset=1&gid=XX&id=XX) - if field has been disabled

[yashodha]

@francescbassas sounds good. @jitendrapurohit Can you please make the requested changes? Is the test failure related?

[eileenmcnaughton]

I don't think the test failure is related - @yashodha go ahead & merge this once you are happy with it

[eileenmcnaughton]

test this please

[jitendrapurohit]

I've updated the PR with the additional requirements. The updated SS is as shown below -

[francescbassas]

To add edit and config group icons:

        $groupEdit = '<a href="' . CRM_Utils_System::url('civicrm/contact/search/advanced', "?reset=1&ssID={$id}", TRUE) . '" title="' . ts('Edit search criteria') . '"> <i class="crm-i fa-pencil"></i> </a>';
        $groupConfig = '<a href="' . CRM_Utils_System::url('civicrm/group', "?reset=1&action=update&id={$id}", TRUE) . '" title="' . ts('Group settings') . '"> <i class="crm-i fa-gear"></i> </a>';
        $html .= "<tr><td>{$id} {$groupEdit} {$groupConfig}</td><td>{$field['title']}</td><td class='disabled'>{$fieldName}</td>";

Aso I would convert the 'ID' and 'Group Title' to one 'Group'

[francescbassas]

Note that I put on $groupConfig the group ID when should be the SSID.

[jitendrapurohit]

@francescbassas The above change has been made. Can you pls retest and confirm? Thanks.

[francescbassas]

Tested and looks good. Thanks @jitendrapurohit.

Looking again, I could just only up the last paragraph above the table.

test this please

[eileenmcnaughton]

test this please

[eileenmcnaughton]

@francescbassas is this good to merge once tests pass?

[jitendrapurohit]

Looking again, I could just only up the last paragraph above the table.

done @francescbassas

[yashodha]

@jitendrapurohit Can you please update the latest screenshot in After section in which all the changes have been incorporated or is this the one https://user-images.githubusercontent.com/1064675/72603392-37b81d00-3919-11ea-8d93-1bc121f6be74.png?

[jitendrapurohit]

@yashodha Done - #16267 (comment)

[yashodha]

@jitendrapurohit looks good, merging this. Thanks!

[eileenmcnaughton]

nice! Thanks all