Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Minor code simplification in dedupe. #16245

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Small readabilty code change

Before

Repeat references to $mainTree[$gid]['fields'][$fid]['customValue']
$foundField works as a clumsy isset

After

variable used for $mainTree[$gid]['fields'][$fid]['customValue']
$foundField replace by a ternary achieving isset

Technical Details

This just tweaks readability by

  1. adding a variable for a value nested fairly deeply in an array
  2. removing the foundField handling in favour of a ternary since
    it's kinda confusing as is

Comments

This just tweaks readability by
1) adding a variable for a value nested fairly deeply in an array
2) removing the foundField handling in favour of a ternary since
it's kinda confusing as is
@civibot
Copy link

civibot bot commented Jan 9, 2020

(Standard links)

@civibot civibot bot added the master label Jan 9, 2020
@eileenmcnaughton eileenmcnaughton merged commit 277a2b1 into civicrm:master Jan 9, 2020
@eileenmcnaughton eileenmcnaughton deleted the dedupe1 branch January 9, 2020 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants