dev/core#1511 Expose option to show event location on configuration tab

[aydun]

Overview

Add a checkbox on the Event Location configuration tab to control whether the location is displayed to users.

The functionality already exists and the field can be configured by API. This enables configuration via the GUI.

Before

The option can only be configured by API.

After

Option can also be configured via GUI.

Technical Details

The logic for the use of the option already exists. This change just exposes it via GUI.

Comments

See https://lab.civicrm.org/dev/core/issues/1511

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@Adyun looks good, tested this and it works fine.

[mattwire]

@aydun The only issue I have here is reading "Show Location?" I have no idea where it is actually shown. If you can clarify via text/description/help text then I'm happy to merge this.

[yashodha]

@mattwire @aydun Would it make sense it to provide the event info link (where the location will be showed or not) so that it is more clear. Something like

Show location here

[aydun]

It affects the location in a few places - I'll add a help note.

[aydun]

Help text added - please re-review.

[yashodha]

@aydun
Can we remove the in first and last and capitalise all or none

• Event Information page
• Event registration confirmation emails
• HTML, RSS and ICALENDAR feeds of event information

[eileenmcnaughton]

(CiviCRM Review Template DEL-1.2)

• General standards

  • Explain (r-explain)

    • PASS : The goal/problem/solution have been adequately explained with a link (JIRA, Github, Gitlab, StackExchange).

  • User impact (r-user)

    • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.

  • Documentation (r-doc)

    • PASS: The changes do not require documentation. There is help text and we checked the docs & didn't see an outdated screenshot Screenshot for event location page needs updating civicrm-user-guide#425

  • Run it (r-run)

    • PASS: We tested this & setting this variable altered how it shows up on the info screen. We weren't able to figure out how to test that it shows on the email - on the test site

  • Technical impact (r-tech)

    • PASS: The change preserves compatibility with existing callers/code/downstream.

  • Code quality (r-code)

    • PASS:

  • Maintainability (r-maint)

    • PASS: The change sufficiently improves test coverage, or the change is trivial enough that it does not require tests because it is only the tpl layer

  • Test results (r-test)

    • PASS: The test results have failures, but these have been individually inspected and found to be irrelevant.

[eileenmcnaughton]

test this pleasee

[seamuslee001]

Test failures unrelated

[homotechsual]

Will this drop in 5.23 or 5.24 -> I suspect 5.24 but am not always entirely sure...

[eileenmcnaughton]

5.23 - 5.22 is the current rc so itt will hit the next one