Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#495 Make admin settings field labels translatable #16227

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

demeritcowboy
Copy link
Contributor

Overview

Follow-on from #16224

Technical Details

I used the following script (on windows - should work similarly on unix):

sed -i -e "s/'title' => '\(.*\),$/'title' => ts('\1),/" Localization.setting.php
grep -v "'description' => NULL," Localization.setting.php > t1.txt
grep -v "'description' => ''," t1.txt > t2.txt
move t2.txt Localization.setting.php
sed -i -e "s/'description' => '\(.*\),$/'description' => ts('\1),/" Localization.setting.php

Then looked over the diff, and also grep "'title'" and grep "'description'" gives a nice visual sanity check.

Comments

My New Year's resolution to use the letter "t" more often is well on target. Also, "s"!

@civibot
Copy link

civibot bot commented Jan 8, 2020

(Standard links)

@civibot civibot bot added the master label Jan 8, 2020
@mattwire mattwire merged commit e8b892b into civicrm:master Jan 8, 2020
@demeritcowboy
Copy link
Contributor Author

Thanks!

@demeritcowboy demeritcowboy deleted the more-t branch January 8, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants