Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CRM_Contact_BAO_Contact::importableFields() to use metadata #16222

Merged
merged 1 commit into from
Jan 7, 2020

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jan 7, 2020

Overview

This squares up the recently added metadata with a hardcoded list in the BAO, removing the list in favor of metadata.

Before

Hardcoded list.

After

Uses metadata to do the same thing.

Notes

I compared the hardcoded array to the metadata line-by-line and the only difference I saw was legal_name which I've added to the metadata.

This squares up the recently added metadata with a hardcoded list in the BAO,
removing the hardcoded list in favor of metadata.
@civibot
Copy link

civibot bot commented Jan 7, 2020

(Standard links)

@civibot civibot bot added the master label Jan 7, 2020
@eileenmcnaughton
Copy link
Contributor

Looks OK to me

@eileenmcnaughton eileenmcnaughton merged commit 44841fe into civicrm:master Jan 7, 2020
@eileenmcnaughton eileenmcnaughton deleted the importable branch January 7, 2020 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants