Refactor CRM_Contact_BAO_Contact::importableFields() to use metadata #16222
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This squares up the recently added metadata with a hardcoded list in the BAO, removing the list in favor of metadata.
Before
Hardcoded list.
After
Uses metadata to do the same thing.
Notes
I compared the hardcoded array to the metadata line-by-line and the only difference I saw was
legal_name
which I've added to the metadata.