Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Add in more assertions around the content of line items and tot… #16218

Conversation

seamuslee001
Copy link
Contributor

…al amount of the contribution record

Overview

This PR adds in some more assertions to the changed fee selection test around the values of the line items

Before

Less assertions

After

more assertions

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Jan 6, 2020

(Standard links)

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 this adds testing so it's OK to merge - but note I've been trying to add in the validateAllPayments to these tests - #16118 - I think my adding might have stalled on the same bug where changeFeeSelection is not correctly creating data for one row

@eileenmcnaughton
Copy link
Contributor

Screen Shot 2020-01-07 at 1 06 17 PM

Looks like the same test

@eileenmcnaughton
Copy link
Contributor

Also note that if we are working in this area we need to keep working on https://docs.civicrm.org/dev/en/latest/financial/financialentities/

@seamuslee001 seamuslee001 merged commit 012171b into civicrm:master Jan 7, 2020
@seamuslee001 seamuslee001 deleted the nfc_add_more_asserts_change_fee_selection branch January 7, 2020 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants