-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Error handling following DB Package upgrade #16213
Merged
eileenmcnaughton
merged 1 commit into
civicrm:master
from
seamuslee001:error_handling_fix
Jan 6, 2020
Merged
Fix Error handling following DB Package upgrade #16213
eileenmcnaughton
merged 1 commit into
civicrm:master
from
seamuslee001:error_handling_fix
Jan 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Standard links)
|
sample error output after patch
|
Jenkins re test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We recently upgraded the DB package such that any DB_Error class error would actually satisfy the
is_callable([$ei, 'getCause'])
now because there has been __call function declared https://github.com/civicrm/civicrm-packages/blob/master/DB.php#L1010Before
E-notice error message about undefined function getCause for DB_Error class see https://test.civicrm.org/job/CiviCRM-Core-Edge/CIVIVER=master,label=test-3/4/testReport/(root)/CRM_Export_BAO_ExportTest/testExportDeceasedDoNotMail_with_data_set__1/ as an example
After
No e-notice error message
ping @eileenmcnaughton