dev/WordPress#2 Modify the WordPress plugin version using distmaker #16211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@seamuslee001 Thanks. I just did an This does improve the situationa nd a good reminder to get back to issue dev/wordpress/2 |
|
Merging this based on @kcristiano 's review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I noticed that the define statement wasn't being modified by dismaker when it runs this fixes it ot modify it when running distmaker, It doesn't solve everything as part of Wordpress#2 but improves the situation IMO
Before
Wordpress plugin version define is not updated by distmaker
After
Wordpress plugin version is updated by distmaker
ping @totten @kcristiano @christianwach