WIP Activity pdf 71 rebased #16200
WIP Activity pdf 71 rebased #16200
Conversation
|
(Standard links)
|
Create CRM_Actvity_Form_Task_PDFLetterCommon extending CRM_Core_Form_Task_PDFLetterCommon
CRM_Activity_Tokens: add source, target and assignee tokens
Eg: {activity.target_N_display_name}
- N can be substituted for a number to show the details of the nth activity target contact
eg: {activity.target_1_display_name} is the display name of the first target
For ease of use, contacts are numbered from 1.
If the literal N is used or is replaced by 0, it is treated as 1.
Slim down alterActionScheduleQuery() and move most data fetching to prefetch()
Add tests for Activity PDF Letter
00191bc to
ed53716
Compare
…ity contacts on token labels
|
Jenkins re test this please |
|
See https://lab.civicrm.org/mattwire/emailapi/tree/newtokenprocessor for a useful way to try it out Also, I renamed Source / Target per @demeritcowboy comments |
|
@mattwire as you picked up this part got stalled over the difficulty of adding a many type token & was considered to be a change that should be documented/discussed/ considered/ resolved in it's own right. I can't recall the details but I guess the place to flesh out how this works is the PR template & then we can try to figure it out. @aydun are there any remaining parts that should be picked off & merged separately or is this all about the many token issue now? |
|
test fails relate here @mattwire |
|
@eileenmcnaughton @mattwire I think all that's left here now are the 'special' tokens. But I also have several other fixes/enhancements for this locally from the October sprint. I'll combine those with Matt's changes. |
|
I'm going to close this as @aydun is planning to pick up the remaining bits (and I'm not likely to) but we don't want them getting lost. Tracking via https://lab.civicrm.org/dev/core/issues/1614 @eileenmcnaughton |
Overview
Rebased #12012 following merge of #14662
Before
What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
After
What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.
Technical Details
If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.
Comments
Anything else you would like the reviewer to note