Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1506 Fix blank group title in recent items list when editing description inline #16197

Merged
merged 1 commit into from
Jan 5, 2020

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Jan 3, 2020

Overview

https://lab.civicrm.org/dev/core/issues/1506
On the Manage Groups screen if you edit the description inline the recent items list will contain a blank entry when you reload the page or then visit another page.

Before

Blank entry in recent items list.

After

Words appear.

Technical Details

Title isn't passed in with the params in the ajax call but it uses title to add to the recent items list. This also affects any Group create api call (v3, or v4 Group update) where you've passed in an id but not a title.

Comments

Has test.

@civibot
Copy link

civibot bot commented Jan 3, 2020

(Standard links)

@civibot civibot bot added the master label Jan 3, 2020
@demeritcowboy
Copy link
Contributor Author

jenkins retest this please

1 similar comment
@seamuslee001
Copy link
Contributor

jenkins retest this please

@seamuslee001
Copy link
Contributor

(CiviCRM Review Template WORD-1.2)

@seamuslee001 seamuslee001 merged commit a99c273 into civicrm:master Jan 5, 2020
@demeritcowboy demeritcowboy deleted the group-recent-items branch January 6, 2020 02:23
@demeritcowboy
Copy link
Contributor Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants