Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Move the storing of custom data into the add function rather th… #16191

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

seamuslee001
Copy link
Contributor

…an in the create function so it is processed before the post hook

Overview

This moves the saving of custom data to within the add() function from the create() function so that any custom data that is processed with the original create is processed before any custom data processing in post hooks. This is similar to #16061

Before

Submitted custom data processed after post hook invocation

After

Submitted custom data is processed before post hook is invoked

ping @eileenmcnaughton

…an in the create function so it is processed before the post hook
@civibot
Copy link

civibot bot commented Jan 2, 2020

(Standard links)

@civibot civibot bot added the master label Jan 2, 2020
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 I've been wondering why we continue to have an add function ... I think originally the idea was that add would be different to create but there is no consistency & I was thinking we should fold add back in to create

@seamuslee001
Copy link
Contributor Author

@eileenmcnaughton yeh i'm not sure either but there maybe something in APIv3 that assumes there will be an add maybe i dunno

@eileenmcnaughton
Copy link
Contributor

No, apiv3 prefers create & falls back on add if it has to

@mattwire
Copy link
Contributor

mattwire commented Jan 3, 2020

@seamuslee001 I'm sure this has come up before and just not got around to change..

@mattwire mattwire merged commit 910a22d into civicrm:master Jan 3, 2020
@eileenmcnaughton eileenmcnaughton deleted the mem_custom_add branch January 3, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants