[NFC] Add test on buildMembershipTypeValues & cleanup class #16167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton test failures related? |
57396a7 to
6e4003e
Compare
|
@eileenmcnaughton It looks like tests are failing again. |
|
test this please |
I found the class wasn't running reliably in isolation so had to strip out some invalid things
|
unrelated fail |
|
Looks fine mostly just test changes merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Cleanup on test class + add a new test - I found the class wasn't running reliably in isolation so had to strip out some invalid things
Before
Various code nastinesses - cleanup issues, wrong params passed, unnecessary double quotes. Incorrect setup resulting in invalid financial entities (line items, transaction)
After
Improved, uses order api
Technical Details
Comments