Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded zendframwork/zend-validator and zendframwork/zend-stdlib packages as not required by … #16112

Merged
merged 2 commits into from
Dec 26, 2019

Conversation

seamuslee001
Copy link
Contributor

…any other package

Overview

This removes an unneeded package from our vendor directory

Before

unneeded package included

After

unneeded package not included

ping @eileenmcnaughton

@civibot
Copy link

civibot bot commented Dec 15, 2019

(Standard links)

@civibot civibot bot added the master label Dec 15, 2019
@seamuslee001 seamuslee001 changed the title Remove unneeded zendframwor/zend-validator package as not required by … Remove unneeded zendframwork/zend-validator package as not required by … Dec 15, 2019
@seamuslee001 seamuslee001 changed the title Remove unneeded zendframwork/zend-validator package as not required by … Remove unneeded zendframwork/zend-validator and zendframwork/zend-stdlib packages as not required by … Dec 17, 2019
@seamuslee001
Copy link
Contributor Author

It looks like both of these packages were originally required by PHPWord package https://github.com/PHPOffice/PHPWord/blob/0.13.0/composer.json#L39 however the zend-validator package was dropped for their 0.14 release https://github.com/PHPOffice/PHPWord/blob/0.14.0/composer.json#L48 and the stdlib was dropped on their 0.15 release (the version we are onto) https://github.com/PHPOffice/PHPWord/blob/0.15.0/composer.json#L60

@seamuslee001
Copy link
Contributor Author

ping @totten @colemanw as well

@totten
Copy link
Member

totten commented Dec 17, 2019

@seamuslee001 Makes sense to me. Skimming the git history of civicrm-core:composer.lock validates (a) that these came in for a previous version of phpword and (b) that none of the other packages are listing it as dependencies.

IMHO, if one can use the autobuild test site to do a light r-run and generate a doc w/phpword, then it's good to go.

@eileenmcnaughton
Copy link
Contributor

test this please

@eileenmcnaughton
Copy link
Contributor

test sites were gone :-(

@seamuslee001
Copy link
Contributor Author

test site should be back now @eileenmcnaughton

@eileenmcnaughton
Copy link
Contributor

Ok - I was still able to create a MS word doc on the test site so I guess all good

@eileenmcnaughton eileenmcnaughton merged commit 75d24d7 into civicrm:master Dec 26, 2019
@eileenmcnaughton eileenmcnaughton deleted the remove_zend_validator branch December 26, 2019 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants