5.13 ESR regression: Fix error on submitting credit card renewals

[mlutfy]

Overview

This is a 5.13 (ESR) backport of #14412.

"Backend -> Contacts' Memberships tab -> hit Renew on a Membership -> Renew Credit Card is what I used to be specific. The payment goes through fine, the Membership is renewed but -> Contribution Receive Date is empty -> so the Contribution ends up at the very bottom of the Contact's Contributions Tab and with no Receive Date"

Reported and tested by @KarinG and @jmcclelland.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mlutfy]

jenkins, test this please

[mlutfy]

Jenkins error:

Starting Drupal installation. This takes a while. Consider using the        [ok]
--notify global option.
Installation complete.                                                      [ok]
Unable to send e-mail. Contact the site administrator if the problem     [error]
persists.
Build step 'Execute shell' marked build as failure
[CHECKSTYLE] Collecting checkstyle analysis files...
[CHECKSTYLE] Searching for all files in /home/jenkins/workspace/CiviCRM-Core-PR that match the pattern checkstyle/*.xml
[CHECKSTYLE] Parsing 1 file in /home/jenkins/workspace/CiviCRM-Core-PR
[CHECKSTYLE] Successfully parsed file /home/jenkins/workspace/CiviCRM-Core-PR/checkstyle/checkstyle-phpcs.xml with 0 unique warnings and 0 duplicates.
Skipping warnings blame since Git is the only supported SCM up to now.%n
[CHECKSTYLE] Computing warning deltas based on reference build #31109
[xUnit] [INFO] - Starting to record.
[xUnit] [INFO] - Processing JUnit
[xUnit] [INFO] - [JUnit] - No test report file(s) were found with the pattern 'junit/*.xml' relative to '/home/jenkins/workspace/CiviCRM-Core-PR' for the testing framework 'JUnit'.  Did you enter a pattern relative to the correct directory?  Did you generate the result report(s) for 'JUnit'?
[xUnit] [ERROR] - No test reports found for the metric 'JUnit' with the resolved pattern 'junit/*.xml'. Configuration error?.
[xUnit] [INFO] - Failing BUILD.
[xUnit] [INFO] - There are errors when processing test results.
[xUnit] [INFO] - Skipping tests recording.
[xUnit] [INFO] - Stop build.
Setting status of 80bc6cec2b0d84f5a6a1c37f446689fc9cb9cd78 to FAILURE with url https://test.civicrm.org:443/job/CiviCRM-Core-PR/31111/ and message: 'Build finished. '
Finished: FAILURE

the "unable to send email" is causing the fail?

[seamuslee001]

also @mlutfy i don't think we are using this branch for the 5.13 ESR @totten will be able to tell you which

[eileenmcnaughton]

What's the plan here - the 5.21 ESR is released on 1 Jan (!) - this is never actually going to be released is it?

[mlutfy]

I think we should have backported this, but from later talks with Tim, it seems that the process is to do an MR on either the security repo, or the esr repo. Will close for now.

[eileenmcnaughton]

@mlutfy it does seem kinda serious - but it lasted 8 months in the ESR so I don't know what to make of that. Anyway 5.13 is pretty much EOL now

[KarinG]

It makes sense if you keep clients on latest security update - there was no reason to move ESR clients off 5.7.x ESR until the recent security updates (which moved them to 5.13.x ESR).

[eileenmcnaughton]

Oh I guess that kinda makes sense. But it also feels like it defeats the purpose of the ESR - ie you are doing a leap-upgrade under the gun of a security release rather than upgrading at a known point in time & then staying stable + if all ESR customers do that then you also lose the benefits of having taken turns at finding any bugs like this that might be in the ESR but not master.

[seamuslee001]

I think there has also been a concern about the ESR point releases (or lack of) which i think is one of the things that partially prompted the shift to the 5.21 rather than 5.19 as the next ESR i think

[KarinG]

We did take one client onto 5.13.x earlier because the security update was going to drop 2days before their Convention. So they were on the prior to release for much longer. And we fixed some issues (most notably exports containing entity references). They do tons with CiviCRM except use that Membership Renewal button. Else we would have run into this earlier. It’s all about strategy/timing per client.