dev/membership#21 Fix regression causing transfer of membership to another contact if they paid

[eileenmcnaughton]

Overview

Fixes a bug where a membership associated with a contact is transferred to the contact who paid for it on edit, if that contact is different.

Before

1. Using default config membership type 'general' is inherited to the head of household - add head of household relationship to an individual
2. Create a membership for the household but check the record payment from a different contact and choose the related individual

3. Go to edit the relationship -note the wrong contact name

4. Edit the end date & save - membership has been transferred to the contact who paid for he membership

After

Contact remains attached to the correct member

Technical Details

This is a regression from work @yashodha did in ac0ef1d to improve form consistency.

Reverting that change fixes this. However, I don't propose we do that because it's a good change and the lines I propose to remove follow a known bad pattern - merging a bunch of parameters into a bunch of parameters with no clarity about what the reason is or why. In fact most of the remove lines exist to reverse the changes made in
CRM_Contribute_BAO_Contribution::getValues($contributionParams, $defaults, $contributionIds);

I couldn't see any negative impact on the renew form & the fields being defaulted didn't even show up on edit

Comments

The gitlab also refers to editing by webform - not sure what that is about

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

This broadly makes sense to me, I'll try and give it some r-run this afternoon

[seamuslee001]

(CiviCRM Review Template WORD-1.2)

• General standards
  • (r-explain) Pass
  • (r-user) Pass
  • (r-doc) Pass
  • (r-run) Pass i replicated the issue and confirmed this fixed it, i also tested renewing the membership on the back end and confirmed that worked fine as well
• Developer standards
  • (r-tech) Pass
  • (r-code) Pass
  • (r-maint) Pass makes code more maintainable
  • (r-test) Pass