Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Fix camelCase variable name following fix for dev/core#1435 #16023

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

seamuslee001
Copy link
Contributor

Overview

Fixes camel casing issue pointed out by @aydun and @yashodha

ping @mattwire @eileenmcnaughton

@civibot civibot bot added the master label Dec 3, 2019
@civibot
Copy link

civibot bot commented Dec 3, 2019

(Standard links)

Copy link
Contributor

@jusfreeman jusfreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seamuslee001 can you just use the same name as retrieved, rather than introduce a different name in the variable?

So do this:
$memberId = CRM_Utils_Request::retrieve('memberId', 'Positive', $this);

Instead of this:
$membershipId = CRM_Utils_Request::retrieve('memberId', 'Positive', $this);

Just keeps things simple.

@eileenmcnaughton
Copy link
Contributor

Hmm my version of keeping things simple is aligning everything with the field name which I thought about doing last patch - ie $contribution_membership_id.

I would say this change is 'better in than out'

@eileenmcnaughton
Copy link
Contributor

@seamuslee001 style issue

@seamuslee001
Copy link
Contributor Author

sorted @eileenmcnaughton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants