Fix retrieving contribution_status_id for manual payment processor

[mattwire]

Overview

I'm not sure if this line ever actually gets hit but if it does it won't work because you need to pass in contribution_status_id and not status_id.

Before

NULL contribution status ID would be retrieved.

After

Pending contribution status ID would be retrieved.

Technical Details

Pseudoconstant requires contribution_status_id not status_id.

Comments

Found while working on some payment related stuff!

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@mattwire test failure looks like it might relate but not 100% sure mate

api_v3_ContributionTest::testpayLater

https://test.civicrm.org/job/CiviCRM-Core-PR/30956/testReport/junit/(root)/api_v3_ContributionTest/testpayLater/

[mattwire]

@seamuslee001 Probably related failure yes, thanks :-( Any thoughts on this one @eileenmcnaughton

[mattwire]

@seamuslee001 @eileenmcnaughton This should just be a simple typo fix - if it passes could you check/merge?

[seamuslee001]

@mattwire same test failure has occurred as before

[mattwire]

@eileenmcnaughton I picked this out as an obvious typo in the manual payment processor rather than a real-world failure. However, fixing it seems to break tests and I can't see why (it's to do with the pay later flag). So I don't know if this is a test error or a problem with the manual processor. And I don't actually use the manual processor anywhere. Any thoughts?

[seamuslee001]

@mattwire i managed to get it to pass again, the issue is that i had to change https://github.com/civicrm/civicrm-core/blob/master/CRM/Contribute/BAO/Contribution/Utils.php#L183 I would note that sets this function to something other than FALSE https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/Payment.php#L1727

[mattwire]

@seamuslee001 Think I finally got it! There was a later code comparison that made the same mistake and returned false - so false == false. Now Pending == Pending!

[seamuslee001]

I agree with this and as far as i can tell the only time that if was true was for manual processor and tested by the ispayLater test.