Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#1425 Remove misleading type hint for Setting value parameter #15988

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

jensschuppe
Copy link
Contributor

Overview

Removes a misleading PHPDoc type hint for the $value parameter in CRM_Core_BAO_Setting::setItem()

Before

IDEs following PHPDoc type hinting expect the $value parameter to be of type object, which is neither the only allowed type for settings values, but especially wrong since CIVI-SA-2019-21 does not allow PHP objects at all in serialized settings values.

After

The type hint is gone, IDEs are happy, erroneous code will be avoided.

Technical Details

See #15975 (comment)

Comments

n/a

@civibot
Copy link

civibot bot commented Nov 29, 2019

(Standard links)

@civibot civibot bot added the master label Nov 29, 2019
@eileenmcnaughton eileenmcnaughton merged commit 124f041 into civicrm:master Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants