dev/core#1425 Remove misleading type hint for Setting value parameter #15988
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Removes a misleading PHPDoc type hint for the
$value
parameter inCRM_Core_BAO_Setting::setItem()
Before
IDEs following PHPDoc type hinting expect the
$value
parameter to be of typeobject
, which is neither the only allowed type for settings values, but especially wrong since CIVI-SA-2019-21 does not allow PHP objects at all in serialized settings values.After
The type hint is gone, IDEs are happy, erroneous code will be avoided.
Technical Details
See #15975 (comment)
Comments
n/a