dev/core#1425 Replace deprecated settings fns in test suite

[eileenmcnaughton]

Overview

Replaces a couple of deprecated function calls in the test suite

Before

CRM_Core_BAO_Setting::setItem

After

Civi::settings()->get

Technical Details

Only tests affected

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@eileenmcnaughton test fail relates

[eileenmcnaughton]

I removed the failing test because in the end it was just testing that something heavily deprecated (mis-storing financial acl settings) works.

We should finish getting those settings out of 'contribution settings' - it would save misery