Make else statement more legible #15974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor readability cleanup part of WTF-reduction regime
Before
We see the equivalent of
The 2 statements in the second part overlap - ie if value == 0 is redundant & the final else only applies when $value !== ''
After
We see the equivalent of
Technical Details
This just condenses the statement since != '' is so broad we know the final
else is only when that is true - ergo it's the same as above
Comments