Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] CSV Export: Remove impossible checks on var #15954

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Removes a small amount of dead code

Before

Variable is hard coded to a double quote but code loops exist just in case it is a single quote

After

Code loops that are unreachable are removed

Technical Details

This variable is hard-coded to a double quote so checks to see if it is a single quote will never be true.

I've checked this pretty thoroughly & I think the removed IFs are dead code

Comments

@civibot
Copy link

civibot bot commented Nov 25, 2019

(Standard links)

This variable is hard-coded to a double quote so checks to see if it is a single quote will never be true.

I've checked this pretty thoroughly & I think the removed IFs are dead code
@seamuslee001
Copy link
Contributor

Yeh this looks very silly

@eileenmcnaughton
Copy link
Contributor Author

lol

@mlutfy mlutfy changed the title [REF] Remove impossible checks on var [REF] CSV Export: Remove impossible checks on var Nov 25, 2019
@mlutfy mlutfy merged commit 9e9bfc4 into civicrm:master Nov 25, 2019
@eileenmcnaughton eileenmcnaughton deleted the ex_silly branch November 25, 2019 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants