Revised version of test from #15725 #15948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I started digging into civicrm#15725 and found that a deprecated methodology was used for the test. I got as far as re-writing the test - although the key lines are commented out as the fix from the above PR is not yet merged
|
(Standard links)
|
|
only affects tests merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds test for #15725
Before
Test not present
After
Test present - but lines relevant to the PR are commented out as not yet fixed - to allow merging
Technical Details
I started digging into #15725 and found that
a deprecated methodology was used for the test. I got as far as re-writing the test
not yet merged
Comments