[REF] return determination of whether to show expired fields to the calling function #15934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alling function As part of my efforts to ensure we are consistency creating valid transactions I'm trying to sort out the way we calculate amounts to be re-usable from tests but I feel stymied at every turn by spaghetti code. This unravels a small piece
|
(Standard links)
|
| @@ -152,7 +157,8 @@ public function buildQuickForm() { | |||
|
|
|||
| //retrieve custom information | |||
| $this->_values = []; | |||
| CRM_Event_Form_Registration::initEventFee($this, $event['id']); | |||
|
|
|||
| CRM_Event_Form_Registration::initEventFee($this, $event['id'], $this->_action !== CRM_Core_Action::UPDATE); | |||
| CRM_Event_Form_Registration_Register::buildAmount($this, TRUE); | |||
There was a problem hiding this comment.
ie FALSE if $form->_action == CRM_Core_Action::UPDATE
|
Makes sense to me looks logically clear merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Minor code cleanup towards larger effort of making amount handling accurately tested
Before
initEventFee determines whether to include expired fields based on a determination of which class is calling it
After
$includeExpiredFields is an input parameter
Technical Details
As part of my efforts to ensure we are consistency creating valid transactions I'm trying to sort out the way we calculate
amounts to be re-usable from tests but I feel stymied at every turn by spaghetti code.
This unravels a small piece
Comments