dev/core#1410 Fix E-notice when doin a force case search with a prede… #15920
Conversation
|
(Standard links)
|
| * | ||
| * @see valid_date | ||
| */ | ||
| public function addRules() { |
There was a problem hiding this comment.
This was code left over after the conversion to date picker
| $query->_qill[$grouping][] = CRM_Contact_BAO_Query::getQillValue('CRM_Case_DAO_Case', $name, $value, $op, 'Case Subject'); | ||
| $query->_tables['civicrm_case'] = $query->_whereTables['civicrm_case'] = 1; | ||
| $query->_tables['civicrm_case_contact'] = $query->_whereTables['civicrm_case_contact'] = 1; | ||
| $query->handleWhereFromMetadata($fieldSpec, $name, $value, $op); |
There was a problem hiding this comment.
Figured made sense to try to standardise the thing even tho this wasn't strictly speaking the issue
|
test this please |
|
Code looks good - @demeritcowboy do you want to test ? |
|
Sure, just I get an error about patch doesn't apply because of whitespace. |
|
@demeritcowboy it should be against 5.20 rather than master just FYI |
0a8d027 to
b6d8291
Compare
|
I wonder if a better solution is just Doing both a url search I'm also noticing something else that must have been introduced between 5.20 and master - I'll make a separate ticket. |
|
@demeritcowboy maybe but there is still some special handling that is in that file so i don't think we can remove it. Given your error i'm thinking maybe i need to put this against master instead or change things @eileenmcnaughton @demeritcowboy should this be a 5.21 or 5.20 thing i can go either way |
|
If this is about url support it's not a regression it's a new feature (out of NYSS interest) I think. I'm all for rm -rf civicrm//Search/ |
|
Yeah I was just joking (well, sort of). I forgot to put the smiley face. |
…fined case subject field
b6d8291 to
11ac6a2
Compare
|
ok @eileenmcnaughton @demeritcowboy i have put this back to master now i think its easier that way |
|
That seems good. Thanks. |
|
@demeritcowboy are you going to do another r-run? |
|
Sorry, I wasn't clear: I did an r-run and it's good for |
|
@demeritcowboy just opened another PR #15924 to resolve your other issue |
|
Thanks! |
|
Looks like this has been tested & code looks good - MOP |
…fined case subject field
Overview
This fixes an issue on the case search form when using a url like
civicrm/case/search?reset=1&force=1&case_subject=testBefore
Notice message
Warning: htmlspecialchars() expects parameter 1 to be string, array given in HTML_Common->_getAttrString()showedAfter
No Notice and search completes correctly
ping @eileenmcnaughton @demeritcowboy