Fix fatal error when sorting by status in activity search

[pfigel]

Overview

This fixes an issue where sorting activity search results by activity status fails with a fatal error because the pseudoconstants are not loaded with the correct field name.

Before

Sorting activity search results by activity status results in a fatal error.

After

Sorting by activity status works.

Technical Details

The underlying issue is that prepareOrderBy() hits buildOptions() with activity_status, but only activity_status_id or status_id would actually return the pseudoconstants. This builds on top of #15899 and sets where for the field as it would otherwise cause a DB error as well (since activity_status is not the name of the column).

Comments

Not entirely sure about this fix - perhaps there's a better place to apply these changes or set an alias for this column. The pseudoconstant bit of the fix could also be done by adding a special case for activity_status in CRM_Activity_BAO_Activity::buildOptions(), but that feels a bit hacky.

I put this against 5.20 since it's similar to #15899, but this regression has been around a bit longer (confirmed broken on 5.13), so I can rebase if needed.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@pfigel alternate proposed solution - #15923

[pfigel]

Closing in favour of #15923