Convert a few fatals to exceptions. #15903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a general thing we are doing. In this case they are all ones that really should never be hit
|
(Standard links)
|
|
Looks fine to me merge on pass |
|
We are very excepting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Further work to replace calls to CRM_Core_Error::fatal with throwing exceptions
Before
Calls to CRM_Core_Error::fatal
After
Exceptions thrown
Technical Details
This is part of general cleanup switching to throwing exceptions of (in the case of form level stuff) statusBounces
Comments
@seamuslee001