Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] [Test-only] Remove partially paid from statuses tested for RenewContribution #15866

Merged
merged 1 commit into from
Nov 18, 2019
Merged

[NFC] [Test-only] Remove partially paid from statuses tested for RenewContribution #15866

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/phpunit/api/v3/ContributionTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2364,11 +2364,14 @@ public function testRepeatTransactionMembershipRenewCompletedContribution() {
* CRM-19945 Tests that Contribute.repeattransaction DOES NOT renew a membership when contribution status=Failed
*
* @dataProvider contributionStatusProvider
*
* @throws \CRM_Core_Exception
*/
public function testRepeatTransactionMembershipRenewContributionNotCompleted($contributionStatus) {
// Completed status should renew so we don't test that here
// In Progress status is only for recurring contributions so we don't test that here
if (in_array($contributionStatus['name'], ['Completed', 'In Progress'])) {
// In Progress status was never actually intended to be available for contributions.
// Partially paid is not valid.
if (in_array($contributionStatus['name'], ['Completed', 'In Progress', 'Partially paid'])) {
return;
}
list($originalContribution, $membership) = $this->setUpAutoRenewMembership();
Expand Down