dev/mem#17 - Deleting memberships does not delete its related line item

[jitendrapurohit]

Overview

Deleting membership does not delete its related line item.

Before

To replicate -

• Create a membership.
• A new row is inserted in civicrm_line_item.
• Delete the membership from civicrm.
• The line item row remains as it is and is never removed from the database.

After

Line Item is deleted after related membership deletion.

Comments

Gitlab - https://lab.civicrm.org/dev/membership/issues/17

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@jitendrapurohit Does this need accompanying tests?

[yashodha]

@jitendrapurohit ping Does this warrant test coverage?

[jitendrapurohit]

The gitlab is still labelled as needs:concept approval so not sure if this would be accepted or not. I can add the test later today or tomorrow :)

[jitendrapurohit]

@yashodha test added for deleted line item.

[yashodha]

@jitendrapurohit great, thanks! I am merging this now.